Pass inst when passing id. #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See reference got updated: BlueBrain/nmodl-references#2 |
This comment has been minimized.
This comment has been minimized.
pramodk
approved these changes
Feb 28, 2024
For functions that are meant to be called "in a loop", i.e. function which accept `id`, we also pass `inst`.
1uc
force-pushed
the
1uc/refactor-internal-signature
branch
from
003b061
to
a73b7b8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1184 +/- ##
=======================================
Coverage 87.17% 87.17%
=======================================
Files 175 175
Lines 12884 12885 +1
=======================================
+ Hits 11232 11233 +1
Misses 1652 1652 ☔ View full report in Codecov by Sentry. |
|
Logfiles from GitLab pipeline #196683 (:white_check_mark:) have been uploaded here! Status and direct links: |
ohm314
pushed a commit
that referenced
this pull request
May 21, 2024
For functions that are meant to be called "in a loop", i.e. function which accept `id`, we also pass `inst`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For functions that are meant to be called "in a loop", i.e. function
which accept
id, we also passinst.